From 6f6d3b10ec8168e2a78cf385d89803397f116397 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roger=20Pau=20Monn=C3=A9?= Date: Fri, 10 Feb 2017 10:42:47 +0100 Subject: [PATCH] x86/iommu: add missing break MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit 50a498 failed to add a break in the p2m_mmio_direct case, so Xen was still not adding IOMMU entries for p2m_mmio_direct regions. Spotted by Coverity. Reported-by: Andrew Cooper Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper --- xen/include/asm-x86/p2m.h | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h index 173a6f825a..c68ff589e1 100644 --- a/xen/include/asm-x86/p2m.h +++ b/xen/include/asm-x86/p2m.h @@ -819,6 +819,7 @@ static inline unsigned int p2m_get_iommu_flags(p2m_type_t p2mt, mfn_t mfn) flags = IOMMUF_readable; if ( !rangeset_contains_singleton(mmio_ro_ranges, mfn_x(mfn)) ) flags |= IOMMUF_writable; + break; default: flags = 0; break; -- 2.30.2